Various bugfixes: Fightfx scale, PalFX BGCtrl and BGPalFX, Game crashes #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, explod creation code divides fightfx anim's start_scale value by char's localscl (which brings ffx anim dimensions to a proper scale) but this operation isn't being performed for other types of actions that support fightfx (ChangeAnim, Projectile, etc). The operation was moved into a common function, so it's applied globally in a character context.
In (*Char) actionRun(), c.minus needs to be 1 before attempting to process next characters, or the game will be prone to crashes when manipulating local variables in ZSS. Code was accommodated accordingly. Also, helpers are now prepared when created, following previous char processing behavior.
This is a temporary "fix" to an issue related to PalFX BGCtrl. How BGPalFX synthesizing should really work: when BGPalFX is applied to a stage, PalFX BGCtrl modifications should be treated like they were part of the original sprites, so a compensation should be applied to PalFX BGCtrl beforehand based on color and invertall values.
[BGDef] needs to be read before [Shadow], so shadows type can be selected correctly. This issue was introduced in 934c114 by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick set of various bugfixes I've been collecting the last month (or so). I focused all of my energies into finding a proper solution for correct synthesizing of BGPalFX into PalFX from BG elements... without good results, so I went for an alternative that works well for now.
Also, I tried to deal with #658 based on observations from my part. The problem might or might not be fully solved, it will depend on further tests, but I can confirm some of the symptoms were lifted.