fix: make round end closer to Mugen's behavior #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ctrl is set to 0 after wait.time - CtrlOver flag behavior changed. It no longer checks for which phase of the round end we are in, but rather it is toggled on when the previous point happens - CtrlOver boolean in the source code renamed to InputOver, as it is more descriptive of what it actually does - Refactor: disabling inputs after wait.time is more simple: the character is directly flagged with NoInput (unless PostRoundInput is active) - Sending characters to their win/lose poses leaves ctrl the way it was instead of changing it to 1 - A side effect of these changes is that the applications of the PostRoundInput flag have been reduced, as that is mostly the new default behavior (like Mugen). This flag can still be used to allow inputs just before the win poses - Basic actions like walking moved back to "action prepare", mostly for compatibility. Guarding instructions are still processed after current state, as that's what is actually responsible for fixing previous bugs
github-actions
bot
added
the
PR: fix
- Juggle points limits are not checked against characters that are not yet in the player's target list, like Mugen
github-actions
bot
added
PR: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl is set to 0 after wait.time
CtrlOver flag behavior changed. It no longer checks for which phase of the round end we are in, but rather it is toggled on when the previous point happens
CtrlOver boolean in the source code renamed to InputOver, as it is more descriptive of what it actually does
Refactor: disabling inputs after wait.time is more simple: the character is directly flagged with NoInput (unless PostRoundInput is active)
Sending characters to their win/lose poses leaves ctrl the way it was instead of changing it to 1 (fixes Kazu's Twitter Meltdown hyper doesn't disable controls #1210)
A side effect of these changes is that the applications of the PostRoundInput flag have been reduced, as that is mostly the new default behavior (like Mugen). This flag can still be used to allow inputs just before the win poses
Other:
Basic actions like walking moved back to "action prepare", mostly for compatibility and redirection. Guarding instructions are still processed after current state, as that's what is actually responsible for fixing previous bugs
Juggle point limits are not checked against characters that are not yet in the player's target list, like Mugen (fixes Partner/helper sharing juggle points #763)