Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add const(data.fall.defence_up) trigger #1149

Merged
merged 4 commits into from
Apr 8, 2023
Merged

feat: add const(data.fall.defence_up) trigger #1149

merged 4 commits into from
Apr 8, 2023

Conversation

potsmugen
Copy link
Contributor

  • Like Mugen, one could not read the character's fall.defence_up constant directly, having to reverse the fall.defence_mul formula to get it. It is now accessible

@github-actions github-actions bot added the PR: feat This PR implements a new feature label Apr 7, 2023
K4thos
K4thos requested changes Apr 8, 2023
View reviewed changes
Copy link
Member

@K4thos K4thos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please also add this to script.go "const"

		case "data.fall.defence_up":
			ln = lua.LNumber(c.gi().data.fall.defence_up)

@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Apr 8, 2023
@potsmugen
Copy link
Contributor Author

Looks like I missed one. Sorry. It is done.

@K4thos K4thos merged commit 556f021 into ikemen-engine:master Apr 8, 2023
@potsmugen potsmugen deleted the const branch April 8, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K4thos K4thos K4thos requested changes

Assignees
No one assigned
Labels
PR: feat This PR implements a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@potsmugen @K4thos