Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dust effect generation #713

Closed
potsmugen opened this issue Nov 11, 2022 · 1 comment · Fixed by #1118
Closed

Dust effect generation #713

potsmugen opened this issue Nov 11, 2022 · 1 comment · Fixed by #1118
Labels
bug Something isn't working

Comments

@potsmugen
Copy link
Contributor

I noticed that there are some scenarios where Ikemen draws automatic dust effects while Mugen doesn't:

  • If you use Kung Fu Throw (or some other throws) in the corner
    ikemen011

  • When hitting the ground after being knocked down
    ikemen013

I did some tests trying to figure out when Mugen creates these dust effects, and here are the conditions I have so far:

  • When a char enters state 52 by using physics = A
  • When a char has all of these conditions:
    • Movetype = H
    • Pos Y = 0
    • Statetype = S or Statetype = C
    • Change in screen position (either velocity or posadd). This means that if chars are pushing into each other or the corner, they will not create dust effects, because their position is not changing even though they have velocities. Ikemen already recreates this

However I suppose that, ideally, these effects wouldn't be hardcoded. Not sure if they are in Ikemen.

@K4thos K4thos added the bug Something isn't working label Nov 19, 2022
@potsmugen
Copy link
Contributor Author

Applies to both 0.98.2 and the latest build.

potsmugen added a commit to potsmugen/Ikemen-GO that referenced this issue Mar 31, 2023
Addresses ikemen-engine#713 and a slight regression in ikemen-engine#1072 that made gethitvar(hittime) start decreasing one frame later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants