Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge distance triggers don't automatically account for different localcoords #1096

Closed
potsmugen opened this issue Mar 27, 2023 · 0 comments · Fixed by #1098
Closed

Edge distance triggers don't automatically account for different localcoords #1096

potsmugen opened this issue Mar 27, 2023 · 0 comments · Fixed by #1098
Labels
bug Something isn't working

Comments

@potsmugen
Copy link
Contributor

potsmugen commented Mar 27, 2023

Describe the bug

Unlike position and velocity and some other triggers, edge distance triggers currently don't account for different localcoords. This means the following triggers:

backedgedist
backedgebodydist
frontedgedist
frontedgebodydist
stagefrontedge
stagebackedge

Return the same values even when a character with one localcoord redirects them to another one with a different localcoord.

(There might be more such cases but it's hard to find them.)

To Reproduce

  1. Put KFM againts KFM 720
  2. Use this to debug KFM:
[State -2, Debug]
type = displaytoclipboard
trigger1 = 1
text = "P2BED = %d P2BEBD = %d P2FED = %d P2FEBD = %d"
params = enemy, backedgedist, enemy, backedgebodydist, enemy, frontedgedist, enemy, frontedgebodydist
ignorehitpause = 1

The return will be different between Mugen 1.1 and Ikemen GO.

Expected behavior

Same as Mugen 1.1

Screenshots / Video

Mugen 1.1
mugen

Ikemen GO (latest)
ikemen017

Engine Version (or source code date)

24/03/2023

Operating system

Windows

Extra context or search terms

No response

@K4thos K4thos added the bug Something isn't working label Mar 27, 2023
K4thos added a commit that referenced this issue Mar 28, 2023
backedge, backedgebodydist, backedgedist, bottomedge, frontedge, frontedgebodydist, frontedgedist, leftedge, rightedge, stagebackedge, stagefrontedge, topedge

Fixes #1096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants