Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters not entering stage sometimes in Tag Team #1043

Closed
AlekBunny opened this issue Mar 11, 2023 · 6 comments
Closed

Characters not entering stage sometimes in Tag Team #1043

AlekBunny opened this issue Mar 11, 2023 · 6 comments
Labels
bug Something isn't working regression Something that used to work correctly

Comments

@AlekBunny
Copy link

AlekBunny commented Mar 11, 2023

Describe the bug

I'm using Ikemen Go 0.99.0-rc.1 Sometimes while playing Tag Team 3x3 or 4x4 the player or AI char doesn't enter the stage after a team member K.O. It happened with the default Kung-Fu Man and also with some Mugen chars. The fist time it occured I thought it could be some conflict with Mugen chars but then testing out with the default Kung-Fu Man the bug showed again.

To Reproduce

I've downloaded chars from mugenarchive.com but the bug also happens with default Kung-Fu Man.

Start Ikemen Go > Arcade > Team Arcade > Select Tag 3x3 or 4x4 and play. In Watch Mode (AI v.s AI) the bug can be reproduced too.
Start Ikemen Go > Watch Mode > CPU Match > Select Tag 3x3 or 4x4 and watch.

Expected behavior

I expect the team members to enter the stage to continue fighting after some member K.O.

Screenshots / Video

Ikemen.Bug.Report.mp4

Engine Version (or source code date)

v0.99.0-rc.1

Operating system

Windows

Extra context or search terms

No response

@AlekBunny AlekBunny changed the title AI Char not entering stage sometimes in Tag Team Characters not entering stage sometimes in Tag Team Mar 11, 2023
@K4thos K4thos added bug Something isn't working regression Something that used to work correctly labels Mar 11, 2023
@potsmugen
Copy link
Contributor

I think this one's an issue with the function that checks which character to tag in (fTagGetPartnerId). I ran 30 matches with the new function code, and 30 with the old code. The new code caused the bug 5 times while the old one did not cause it at all.

@AlekBunny
Copy link
Author

AlekBunny commented Mar 12, 2023

@potsmugen Hi! Thanks for the info! =:) What Ikemen version did you use? The one that isn't causing this bug?

@potsmugen
Copy link
Contributor

I used the same one you did, then modified it a bit to see what was causing the bug. Until it gets fixed you can just use the tag.zss file from the 0.98.2 version.

@AxeLanderMoreira
Copy link

Jumping into the discussion, I was testing the same scenario (watch mode tag team 4v4) to try and reproduce an old crash (#658 ), which by the way has been fixed, and got the same issue described here.

@potsmugen , I tried using just the tag.zss file from 0.98.2 version*, while keeping all of the other binary files and data files from 0.99.1 version; then I get a different bug where the other characters in the team will not leave the screen upon the beginning of the round. So I guess that the old tag.zss file is not really compatible.

K4thos added a commit that referenced this issue Mar 12, 2023
K4thos added a commit that referenced this issue Mar 12, 2023
fix: tag.zss regression, characters not entering stage (#1043)
@K4thos K4thos closed this as completed Mar 12, 2023
@AxeLanderMoreira
Copy link

Latest tag.zss confirmed as fixing the issue, on my side.

@AlekBunny
Copy link
Author

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something that used to work correctly
Projects
None yet
Development

No branches or pull requests

4 participants