Crash in create_list_request when list name is missing sympa-communit…

…y#490
ikedas · Dec 3, 2018 · 6b09681 · 6b09681
1 parent 3fb4ac1
commit 6b09681
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/lib/Sympa/Aliases.pm b/src/lib/Sympa/Aliases.pm
@@ -93,8 +93,10 @@ sub check_new_listname {
     my $listname = shift;
     my $robot_id = shift;
 
-    die 'bug in logic. Ask developer'
-        unless defined $listname and length $listname;
+    unless (defined $listname and length $listname) {
+        $log->syslog('err', 'No listname');
+        return ('user', 'listname_needed');
+    }
 
     $listname = lc $listname;
 

diff --git a/src/lib/Sympa/Request/Handler/move_list.pm b/src/lib/Sympa/Request/Handler/move_list.pm
@@ -60,7 +60,7 @@ sub _twist {
 
     my $robot_id     = $request->{context};
     my $current_list = $request->{current_list};
-    my $listname     = lc $request->{listname};
+    my $listname     = lc($request->{listname} || '');
     my $mode         = $request->{mode};
     my $pending      = $request->{pending};
     my $notify       = $request->{notify};