fix(playground): always set language to trigger the tree-sitter language onChange event #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set default language to `yaml` by `js`, because use html set the default select value does't trigger the `tree-sitter.js` onChange event
|
Closes #8 |
ikatyang
reviewed
Sep 30, 2020
docs/index.html
Outdated
| @@ -117,3 +117,8 @@ <h4>Tree</h4> | |||
| src="https://code.jquery.com/jquery-3.3.1.min.js" | |||
| crossorigin="anonymous"> | |||
| </script> | |||
| <script> | |||
| let select = document.getElementById('language-select') | |||
| select.nodeValue = 'yaml' | |||
There was a problem hiding this comment.
The event is registered via addEventListener, so we probably need to use dispatchEvent to trigger it:
Suggested change
| select.nodeValue = 'yaml' | |
| select.value = 'yaml' | |
| select.dispatchEvent(new Event('change')) |
There was a problem hiding this comment.
just change the value is enough, i have try it.
There was a problem hiding this comment.
Can you share the steps to reproduce & verify? Only changing the value does not seem to work on my machine (Chrome on macOS).
ikatyang
changed the title
ikatyang
approved these changes
Oct 1, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
set default language to
yamlbyjs, because use html set the default select value does't trigger thetree-sitter.jsonChange event