Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist ordering and mime #173

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

izderadicka
Copy link
Contributor

Thanks for #172 - definitely better code organization, just couple of edits from my linux perspective:

  • torrent PL should be sorted by filename, torrent file id ordering is often not "natural"
  • apple MIME is not working well with VLC on linux - so leaving it for apple platforms, simple text/plain works on linux fine.

@izderadicka
Copy link
Contributor Author

On b38c371 test failure was caused by platform variations? Same code, except comment in next commit.

@ikatson ikatson merged commit 62067b2 into ikatson:main Aug 9, 2024
4 checks passed
@ikatson
Copy link
Owner

ikatson commented Aug 10, 2024

The tests flake out sometimes, must be a bug somewhere.

Your code style was good btw, I only split it up to reuse parts of your function.

Btw I tried pasting the playlist URL into VLC and it doesn't seem to work: it seems VLC expects playlist to be a local file, and when pasting into "open network" (or whatever it's called) nothing happens. Only if I download the playlist, then open it works.

Is it the same for you or I'm doing something wrong?

@izderadicka
Copy link
Contributor Author

@ikatson Opening playlist URL in VLC works for me on linux, if MIME is text/plain - I think VLC has problem with apple MIME type - application/vnd.apple.mpegurl - that's why I left it there only for Apple platforms. This MIME is officially for Apple HLS - and this is not our use case. But I thought, as you added this MIME, it might have some advantage on Apple?

Or with this MIME, it might require extended M3U syntax - e.g. start with #M3UEXT line etc. Will try

@ikatson
Copy link
Owner

ikatson commented Aug 10, 2024

Opening playlist URL in VLC works for me on linux, if MIME is text/plain

Thanks, that explains why nothing actually worked for me on Mac! I added MIME type there not because it wasn't working without it, but just because the wikipedia page for M3U was listing this mime type on the first line.

It actually says later that that apple one is for HLS (and I didn't read that at first), and a better one to use for general M3U is e.g. "application/mpegurl".

Fixing this here: #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants