Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency pug to v3 [SECURITY] #2

Merged
merged 1 commit into from
May 27, 2021

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented May 5, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pug (source) 2.0.0-beta11 -> 3.0.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2021-21353

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to [email protected] or [email protected] or [email protected], which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: pugjs/pug#3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy


Release Notes

pugjs/pug

v3.0.1

Compare Source

Bug Fixes

  • Sanitise the pretty option (#​3314)

    If a malicious attacker could control the pretty option, it was possible for them to achieve remote code execution on the server rendering the template. All pug users should upgrade as soon as possible, see #​3312 for more details.

v3.0.0

Compare Source

Breaking Changes

  • read plugins must now return Buffer if you want to support filters that use renderBuffer (#​3213)

    If you don't wish to support this advanced use case, you can continue returning string. If you did not provide a read plugin, you do not need to do anything.

  • The minify option on filters now requires you to install the relevant jstransformer (#​3084)

    Currently we support:

    • jstransformer-uglify-js for JavaScript
    • jstransformer-clean-css for CSS
  • Drop support for node 6 and 8 (#​3243)

New Features

  • Support filters that apply to Buffers (#​3213)

    e.g.

    // options.js
    exports.filters = {
      png: {
        // instead of a function, specify an object with a "renderBuffer" property
        // whose value is a function that takes a Buffer instead of a string
        renderBuffer: function(buffer, options) {
          var data = Buffer.from(buffer).toString('base64');
          return '<img src="data:image/png;base64, ' + data + '"/>';
        }
      }
    };

    You can then use the filter like:

    // foo.pug
    include:png my-small-image.png
  • Add support for replacing code gen via a plugin with generateCode (#​3230)

  • Support each ... of ... loops (#​3179)

    each value of iterable
      li= value

    This requires an environment that supports the for (const val of iterable) syntax in JS. You can iterate over Maps, Sets etc. as well as arrays. There is also some destructuring of map keys:

    - const map = new Map([['a', 'x'], ['b', 'y']]);
    each [key, value] of map
      li
        strong= key
        = value

v2.0.4

Compare Source

  • fix: improve error message when requiring a filter that's not installed
  • fix: toJSON is now only called on object-like values
  • fix: preLex plugins were not called when compiling from a string
  • perf: add "files" property to exclude un-used files from package and reduce install size
  • feat: support ... spread attributes when compiling to JSX N.B. this will not work when rendering to HTML

v2.0.3

Compare Source

  • fix: update clean-css dependency. This resolves a RegExp DoS vulnerability that should not have impacted any pug users (unless you process un-trusted pug source code)

v2.0.2

Compare Source

v2.0.1

Compare Source

v2.0.0

Compare Source

v2.0.0-rc.4

Compare Source

v2.0.0-rc.3

Compare Source

v2.0.0-rc.2

Compare Source

v2.0.0-rc.1

Compare Source

v2.0.0-beta9

Compare Source

v2.0.0-beta8

Compare Source

v2.0.0-beta7

Compare Source

v2.0.0-beta6

Compare Source

v2.0.0-beta5

Compare Source

v2.0.0-beta4

Compare Source

v2.0.0-beta3

Compare Source

v2.0.0-beta2

Compare Source


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch from 9e47496 to b54f994 Compare May 27, 2021 06:06
@ivankatliarchuk ivankatliarchuk merged commit ab64a59 into master May 27, 2021
@ivankatliarchuk ivankatliarchuk deleted the renovate/npm-pug-vulnerability branch May 27, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants