Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed @embroider/[email protected] to allow nesting v2 addons #36

Merged
merged 2 commits into from
May 9, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented May 9, 2023

Description

When a v2 addon depends on [email protected] (also a v2 addon), running the consuming app (or building its test app) results in an error:

Cannot read properties of undefined (reading 'registerV2Addon')

Related: embroider-build/embroider#1325

@ijlee2 ijlee2 added the bug Something isn't working label May 9, 2023
@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for embroider-css-modules ready!

Name Link
🔨 Latest commit d73bfbb
🔍 Latest deploy log https://app.netlify.com/sites/embroider-css-modules/deploys/6459ec9f55d78d000822c2da
😎 Deploy Preview https://deploy-preview-36--embroider-css-modules.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ijlee2 ijlee2 marked this pull request as ready for review May 9, 2023 06:50
@ijlee2 ijlee2 merged commit a9a208d into main May 9, 2023
@ijlee2 ijlee2 deleted the bugfix-update-addon-shim-to-1.8.5-unstable branch May 9, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant