-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed the helpers by dropping the cq prefix #146
Changes from all commits
70db951
96a23e9
869784a
9c42cf9
140476f
8df608b
20dc3b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,16 @@ | ||
import type ContainerQueryComponent from 'ember-container-query/components/container-query'; | ||
import type CqAspectRatioHelper from 'ember-container-query/helpers/cq-aspect-ratio'; | ||
import type CqHeightHelper from 'ember-container-query/helpers/cq-height'; | ||
import type CqWidthHelper from 'ember-container-query/helpers/cq-width'; | ||
import type AspectRatioHelper from 'ember-container-query/helpers/aspect-ratio'; | ||
import type HeightHelper from 'ember-container-query/helpers/height'; | ||
import type WidthHelper from 'ember-container-query/helpers/width'; | ||
import type ContainerQueryModifier from 'ember-container-query/modifiers/container-query'; | ||
|
||
export default interface EmberContainerQueryRegistry { | ||
ContainerQuery: typeof ContainerQueryComponent; | ||
'aspect-ratio': typeof AspectRatioHelper; | ||
'container-query': typeof ContainerQueryModifier; | ||
'cq-aspect-ratio': typeof CqAspectRatioHelper; | ||
'cq-height': typeof CqHeightHelper; | ||
'cq-width': typeof CqWidthHelper; | ||
'cq-aspect-ratio': typeof AspectRatioHelper; | ||
'cq-height': typeof HeightHelper; | ||
'cq-width': typeof WidthHelper; | ||
height: typeof HeightHelper; | ||
width: typeof WidthHelper; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { default } from 'ember-container-query/helpers/aspect-ratio'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,18 @@ | ||
export { default } from 'ember-container-query/helpers/cq-aspect-ratio'; | ||
import { deprecate } from '@ember/debug'; | ||
|
||
deprecate( | ||
'The {{cq-aspect-ratio}} helper has been renamed to {{aspect-ratio}}. Please update the helper name in your template.', | ||
false, | ||
{ | ||
for: 'ember-container-query', | ||
id: 'ember-container-query.rename-cq-aspect-ratio-helper', | ||
since: { | ||
available: '3.2.0', | ||
enabled: '3.2.0', | ||
}, | ||
until: '4.0.0', | ||
url: 'https://github.com/ijlee2/ember-container-query/tree/3.2.0#api', | ||
} | ||
); | ||
|
||
export { default } from 'ember-container-query/helpers/aspect-ratio'; | ||
Comment on lines
+1
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reminder Remove these lines in the future pull request, which will remove |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,18 @@ | ||
export { default } from 'ember-container-query/helpers/cq-height'; | ||
import { deprecate } from '@ember/debug'; | ||
|
||
deprecate( | ||
'The {{cq-height}} helper has been renamed to {{height}}. Please update the helper name in your template.', | ||
false, | ||
{ | ||
for: 'ember-container-query', | ||
id: 'ember-container-query.rename-cq-height-helper', | ||
since: { | ||
available: '3.2.0', | ||
enabled: '3.2.0', | ||
}, | ||
until: '4.0.0', | ||
url: 'https://github.com/ijlee2/ember-container-query/tree/3.2.0#api', | ||
} | ||
); | ||
|
||
export { default } from 'ember-container-query/helpers/height'; | ||
Comment on lines
+1
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reminder Remove these lines in the future pull request, which will remove |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,18 @@ | ||
export { default } from 'ember-container-query/helpers/cq-width'; | ||
import { deprecate } from '@ember/debug'; | ||
|
||
deprecate( | ||
'The {{cq-width}} helper has been renamed to {{width}}. Please update the helper name in your template.', | ||
false, | ||
{ | ||
for: 'ember-container-query', | ||
id: 'ember-container-query.rename-cq-width-helper', | ||
since: { | ||
available: '3.2.0', | ||
enabled: '3.2.0', | ||
}, | ||
until: '4.0.0', | ||
url: 'https://github.com/ijlee2/ember-container-query/tree/3.2.0#api', | ||
} | ||
); | ||
|
||
export { default } from 'ember-container-query/helpers/width'; | ||
Comment on lines
+1
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reminder Remove these lines in the future pull request, which will remove |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { default } from 'ember-container-query/helpers/height'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { default } from 'ember-container-query/helpers/width'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder
Remove these lines in the future pull request, which will remove
{{cq-aspect-ratio}}
,{{cq-height}}
, and{{cq-width}}
helpers.