Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Master branch: canvas_ribbon can't display normally #1935

Closed
3 tasks done
leviding opened this issue Oct 11, 2017 · 9 comments
Closed
3 tasks done

Latest Master branch: canvas_ribbon can't display normally #1935

leviding opened this issue Oct 11, 2017 · 9 comments
Labels

Comments

@leviding
Copy link
Contributor

I agree and want to create new issue


Expected behavior

canvas_ribbon display normally

Actual behavior

canvas_ribbon can't display normally

Steps to reproduce the behavior

canvas_ribbon can't normal display. And I downloaded the Latest Master branch to test, I only change as follow, canvas_ribbon still can't normal display.

the file _config.yml

# Schemes
scheme: Muse
#scheme: Mist
#scheme: Pisces
#scheme: Gemini

canvas_ribbon: false

to

# Schemes
#scheme: Muse
#scheme: Mist
scheme: Pisces
#scheme: Gemini

canvas_ribbon: true
  • Link to demo site with this issue: N/A
  • Link(s) to source code or any usefull link(s): N/A

Hexo Information


NexT Information

NexT Version:

[x] Latest Master branch.
[] Latest Release version.
[] Old version - 

NexT Scheme:

[] All schemes
[] Muse
[] Mist
[x] Pisces
[] Gemini

Other Information

none.

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Oct 11, 2017

Can u please to check this pull: #1932?

OR

Try to follow next steps:

  1. Backup your source of themes/next directory.
  2. Switch to latest release version (see Download latest master branch. section in main readme).
  3. Try to catch same error by refreshing browser with CTRL + SHIFT + R.

@leviding
Copy link
Contributor Author

leviding commented Oct 11, 2017

Yes, I change to the latest release version, anvas_ribbon display normally, but I change to the Latest Master branch to test, canvas_ribbon can't normal displaied. I think the problem may come from the PR #1932 .

Thanks for your answer.

Fingly, I only delete the old canvas-ribbon.js, and copy the canvas-ribbon.js of the latest release version to my next theme, fix the problem.

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Oct 11, 2017

Can u give some more info about this bug? What log in your cosole show during this error?
As i see, your blog have 5.1.2 version. U test canvas on localhost?
And could you please provide the following information?

  • Node.js and NPM version ($node -v && npm -v)?
  • Hexo version ($hexo -v)?
  • Your site package dependencies ($cat package.json)?

@leviding
Copy link
Contributor Author

  • Node.js v8.1.4
  • NPM -v5.3.0
  • Hexo -v3.3.7
hexo: 3.3.7
hexo-cli: 1.0.3
os: Windows_NT 10.0.14393 win32 x64
http_parser: 2.7.0
node: 8.1.4
v8: 5.8.283.41
uv: 1.12.0
zlib: 1.2.11
ares: 1.10.1-DEV
modules: 57
openssl: 1.0.2l
icu: 59.1
unicode: 9.0
cldr: 31.0.1
tz: 2017b
  • package.json
{
  "name": "hexo-site",
  "version": "0.0.0",
  "private": true,
  "hexo": {
    "version": "3.3.7"
  },
  "dependencies": {
    "hexo": "^3.2.0",
    "hexo-deployer-git": "^0.2.0",
    "hexo-generator-archive": "^0.1.4",
    "hexo-generator-baidu-sitemap": "^0.1.1",
    "hexo-generator-category": "^0.1.3",
    "hexo-generator-feed": "^1.2.0",
    "hexo-generator-index": "^0.2.0",
    "hexo-generator-json-content": "^3.0.1",
    "hexo-generator-searchdb": "^1.0.3",
    "hexo-generator-sitemap": "^1.1.2",
    "hexo-generator-tag": "^0.2.0",
    "hexo-renderer-ejs": "^0.2.0",
    "hexo-renderer-marked": "^0.2.10",
    "hexo-renderer-stylus": "^0.3.1",
    "hexo-server": "^0.2.0",
    "hexo-wordcount": "^2.0.1"
  }
}

image

image

@ivan-nginx
Copy link
Collaborator

@leviding thanks! Well, need to wait answer from @geekrainy.

@ivan-nginx ivan-nginx added the Bug label Oct 11, 2017
@leviding
Copy link
Contributor Author

@ivan-nginx Thanks for your answer.
And thank you @geekrainy.

@geekrainy
Copy link
Contributor

Sorry, This is my fault. Just fix it. #1936

@ivan-nginx
Copy link
Collaborator

@leviding issue was automatically closed. All worked fine?

Raincal pushed a commit to Raincal/hexo-next that referenced this issue Oct 11, 2017
@leviding
Copy link
Contributor Author

@ivan-nginx Yes, that's great, thank you so much.
@geekrainy And thank you.

wafer-li pushed a commit to wafer-li/hexo-theme-next that referenced this issue Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants