Add Battery Stat #117
Merged
Add Battery Stat #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stat so far can only handle one battery (BAT0), so it is still incomplete.
This makes the battery stat no longer hard-coded to BAT0. However, this is clunky and is not preferred. The preferred method is setting it inside of config.toml, but I'm not sure if that's possible to implement.
This commit removes Catnap choosing a battery via the CATNAP_BATTERY environment variable. It now uses a regex search to determine the default battery. Unfortunately, I'm still not able to set the chosen battery via config.toml, so this will have to be sufficient.
|
Thx! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your pull request linked to an existing issue?
#115
What is your pull request about?:
Adds a battery stat. How it works is Catnap uses a regex search to find the default battery in
/sys/class/power_supply/.Any other disclosures/notices/things to add?
I'm still looking for a way to set the chosen battery in
config.toml. Contributions appreciated.Credits to https://gitlab.com/prashere/battinfo for the regex stuff.