-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #790
Update CI #790
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
=====================================
Coverage 95.2% 95.2%
=====================================
Files 46 46
Lines 4335 4335
=====================================
Hits 4130 4130
Misses 205 205 |
d1f1cc9
to
369e830
Compare
@khaeru This PR is ready in principle, the only thing we might want to still adapt is the pre-commit action usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to go. There is some added whitespace on empty lines in pytest.yaml, I guess unintentional.
I'd vote that we make a general decision on how to invoke pre-commit and then implement it later.
Good catch, thanks :) |
* Bump cache-action version * Bump Codecov-action version using newly added repo secret * Remove temporary genno pin * Configure dependabot to update GHA versions * Use quotation marks as in GH docs example * Include suggested solution, bump setup-graphviz * Remove unintentional whitespace * Provide token input to codecov action
Closes #788. This PR updates the CI to address several minor issues:
We can also use this to solve the current CI failure of the windows-tutorials test. As far as I can see, this failure stems from a cache being used -- at least, the setup-gams step does not fail for the other windows-CI-tests not using a cache for gams. (was resolved by iiasa/actions#12)
How to review
PR checklist
[ ] Add, expand, or update documentation.Just CI updates[ ] Update release notes.Just CI updates