-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test genno vs. legacy reporting #178
Draft
khaeru
wants to merge
11
commits into
main
Choose a base branch
from
enh/test-report
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+178
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaeru
added
report
genno-based reporting and post-solve processing
report-legacy
Legacy reporting
labels
Apr 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
+ Coverage 58.8% 58.9% +0.1%
=======================================
Files 194 194
Lines 15159 15224 +65
=======================================
+ Hits 8922 8978 +56
- Misses 6237 6246 +9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
.test_report.test_compare()
, and associated utility function that:This functions as a test of known differences between the output of the legacy and genno-based reporting for this particular scenario. The added variable IGNORE can be extended and modified as the genno-based reporting is expanded towards feature parity with the legacy reporting.
Also:
default_units.yaml
to suppress some of the many warnings about missing "conversion factors"..report.Config.modules
and.iter_callbacks()
.How to review
TBA
PR checklist