Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of GHAs #518

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Feb 6, 2024

This PR is a follow-up of #517 and bumps the remaining versions except for pre-commit, which seems unwilling to release a new version at the moment.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ Just CI update
  • [ ] Add, expand, or update documentation. Just CI update
  • [ ] Update release notes. Just CI update

@glatterf42 glatterf42 added ci Continuous integration dependencies Pull requests that update a dependency file labels Feb 6, 2024
@glatterf42 glatterf42 added this to the 3.9 milestone Feb 6, 2024
@glatterf42 glatterf42 self-assigned this Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b93531) 98.9% compared to head (f0fb3f0) 98.9%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #518   +/-   ##
=====================================
  Coverage   98.9%   98.9%           
=====================================
  Files         44      44           
  Lines       4795    4795           
=====================================
  Hits        4743    4743           
  Misses        52      52           

@khaeru
Copy link
Member

khaeru commented Feb 6, 2024

Seeing pre-commit/action#188 and pre-commit/action#189, it seems like that action is not "in maintenance mode" per the README but in fact not maintained.

At transport-data/tools#14 I copied the steps into the workflow directly, updated actions/cache and it's not a lot longer than using the third-party one. (The step for clearing the cache daily is actually simpler and easier to read.) That's one option for our stack.

@glatterf42 glatterf42 requested a review from khaeru February 6, 2024 13:22
@glatterf42 glatterf42 merged commit 049689a into iiasa:main Feb 6, 2024
21 checks passed
@glatterf42 glatterf42 deleted the update/ci-versions branch February 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants