Try to fix failing build on AppVeyor #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zikolach
commented
Mar 23, 2020
zikolach
commented
- remove finally block in timeseries commit method
- change input validation in setStatus method
- fix commit in Scenario class
- propagate exceptions from commit
- upgrade pytest dependency
- tee stdout on appveyor
|
AppVeyor build 517 passed. The logs are, I guess as expected, very long. @zikolach can you look through and collect any noteworthy information, then try removing the Line 40 in 78628a6 After that we can merge and continue with #289. |
zikolach
force-pushed
the
feature/xlsx-io-2-extra
branch
from
56e50f0 to
8abcf95
Compare
khaeru
requested changes
Mar 24, 2020
zikolach
force-pushed
the
feature/xlsx-io-2-extra
branch
from
52844d2 to
7620b8b
Compare
- remove finally block in timeseries commit method (java) - change input validation in setStatus method (java) - fix commit in Scenario class (java) - propagate exceptions from commit (java) - upgrade pytest dependency - add platform method to get current log level (remove changing log level in tests as it affects other tests log output) - updated ixmp.jar (source diff https://github.com/iiasa/ixmp_source/compare/10742197121eaf83c6f222f969d7e2842d0bbdde...923f5b9b3c283c31f5ea6deb0854548a11144599)
zikolach
force-pushed
the
feature/xlsx-io-2-extra
branch
from
7620b8b to
1a3f373
Compare
khaeru
approved these changes
Mar 24, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.