Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIxed recommended config for legacy eslintrc config format #36

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

ihordiachenko
Copy link
Owner

Fix #35 by splitting the recommended preset for flat config(ESLint 9) and legacy erslintrc config(ESLint < 9).

Usage in eslintrc remains the same. Usage in flat configs will looks like this:

const pluginChaiFriendly = require("eslint-plugin-chai-friendly");

module.exports = [
    pluginChaiFriendly.configs.recommendedV9, // note the V9 suffix
    // other configurations
]

This is a breaking change.

@ihordiachenko
Copy link
Owner Author

@brettz9 could you take a look?

@brettz9
Copy link
Contributor

brettz9 commented Jun 3, 2024

@brettz9 could you take a look?

Works for me (testing both flat format with ESLint 9 and regular and flat format with ESLint 8)

@brettz9
Copy link
Contributor

brettz9 commented Jun 3, 2024

However, sorry to think of this belatedly, but I think something like "recommendedFlat" would be a better config name since flat config has started in ESLint 8 and may continue beyond ESLint 9.

@ihordiachenko
Copy link
Owner Author

However, sorry to think of this belatedly, but I think something like "recommendedFlat" would be a better config name since flat config has started in ESLint 8 and may continue beyond ESLint 9.

Good point, renaming it to recommendedFlat

@ihordiachenko ihordiachenko merged commit 7d1d73e into master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.8.0 does not work with ESLint v8.x
2 participants