Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sbachmei/fix default results dir and max workers #198

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Feature/sbachmei/fix default results dir and max workers #198

merged 3 commits into from
Oct 30, 2023

Conversation

stevebachmeier
Copy link
Contributor

Remove default results dir; add default max workers

Description

  • Category: other
  • JIRA issue: na

Changes and notes

  • Removes default results directory for psimulate run
  • Modifies defaults output directory for psimulate test
  • Adds a --max-workers default of 8000

Testing

tested changes locally

@stevebachmeier stevebachmeier merged commit e8e6b73 into main Oct 30, 2023
@stevebachmeier stevebachmeier deleted the feature/sbachmei/fix-default-results-dir-and-max-workers branch October 30, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkappel mattkappel mattkappel approved these changes

@rmudambi rmudambi rmudambi approved these changes

@albrja albrja Awaiting requested review from albrja albrja is a code owner

@collijk collijk Awaiting requested review from collijk collijk is a code owner

@hussain-jafari hussain-jafari Awaiting requested review from hussain-jafari hussain-jafari is a code owner

@patricktnast patricktnast Awaiting requested review from patricktnast patricktnast is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevebachmeier @rmudambi @mattkappel