Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues for CRAN submission and pushrelease actions #123

Merged
merged 12 commits into from
May 3, 2022
Merged

Conversation

BBieri
Copy link
Collaborator

@BBieri BBieri commented May 2, 2022

Description

Package

  • Fixed invalid URLs mentioned in the CRAN comments
  • Fixed case-sensitive path extension for Linux checks in various vignettes
  • Fixed various issues in the pushrelease workflow
    • Release action was fixed by updating tag creation action
    • Setup-R action was updated to v2
    • Installing Xquartz dependency for macOS runner building the website since
      the latest version of {pdftools} requires it
  • Packages used in GitHub Actions were moved to suggests in Description

Checklist:

  • PR form
    • I have given this pull request an informative title
    • Description above itemizes changes under subtitles, e.g. "## Collection""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
    • CodeFactor check: Package improves or maintains good style
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Any longer functions are commented inline so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

@BBieri BBieri requested a review from jhollway May 2, 2022 13:03
@BBieri BBieri self-assigned this May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #123 (c63fa13) into main (65b733a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   52.22%   52.22%           
=======================================
  Files          13       13           
  Lines         404      404           
=======================================
  Hits          211      211           
  Misses        193      193           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b733a...c63fa13. Read the comment docs.

@jhollway jhollway merged commit c2ee2c6 into main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants