♻️ Convert the Domain module to a KMP module #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update aboutlibraries to v10.8.3
igorescodro
force-pushed
the
amm/domain
branch
2 times, most recently
from
07f1333 to
6a7db6b
Compare
Update kotlinx.coroutines to v1.7.3
Update dependency io.insert-koin:koin-test to v3.4.3
Update dependency io.insert-koin:koin-android to v3.4.3
igorescodro
force-pushed
the
amm/domain
branch
2 times, most recently
from
8026dbe to
1ff1b99
Compare
igorescodro
changed the title
Update dependency io.insert-koin:koin-androidx-compose to v3.4.6
Fix the `packagingOptions` and `textFieldColors` deprecations
Update dependency io.insert-koin:koin-core to v3.4.3
A new `shared` module was create to hold all the shared logic between the different mobile platforms. Future changes will make the `shared` module the new `domain` if possible. Since the `:domain` module is already Kotlin-only, the code was simply moved and works!
Moved the dependencies from the Kotlin-only to the Kotlin Multiplatform Mobile one
For some reason, Kotlin-only modules do not find the KMM modules. This module was temporarily converted to Android to make the code work. In the future, this module will also be a KMM one.
Small back-and-forth to convert the `shared` to the old `domain`. Now that everything is set, the module was updated to the original name.
Oopsy, I removed the tests when moving the class between the modules. The classes are now back and removed the junit dependencies since it doesn't work well with KMM.
Removing Java's Calendar and adapting the logging tool to its multiplatform version. Some work was needed for the convertions since the Android layers will keep using Calendar for now. Future commits will address the TODOs and make it more clear.
Fix the logging system in the remaining use cases and also some oopsies along the way.
All the domain tests are working fine again all the Calendar/DateTime migration
A few lint complaints
Instrumented tests fixed
When renaming the module from "shared" to "domain", one property was missed. Updated!
When migrating to KMM, the checkers were removed from the Gradle script. The quality plugin was re-added and the lint fixes updated.
Now that everything is set on the correct KMM directory, no need to keep this folder anymore.
When running the Android Test task, KMP requires the minimum SDK to 30
to allow space in the test names. Another solution is to remove the
spaces and use simple names. The following regex was used to make the
job easier:
\s+(?=(?:(?:[^`]*`){2})*[^`]*`[^`]*$)
The Instant API requires min SDK 26, so we can't use the emulator on 24 anymore
Previously, some versions were inside the Version Catalog TOML and others were in the AlkaaVersions file. Since the versioning and compiling will be even more important now that we will compile with KMP, all the versions are centralized in a single place. Also, the VersionCatalogExtensions was broken in several classes to make it easier to understand. They are: Bundles, Libraries and Versions.
igorescodro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step to convert Alkaa to Kotlin Multiplatform Mobile! The domain layer is already a Kotlin-only module, which make the process much easier.