Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blop.wav not reproducing on Firefox #23

Closed
lisandro52 opened this issue Sep 4, 2015 · 1 comment
Closed

Blop.wav not reproducing on Firefox #23

lisandro52 opened this issue Sep 4, 2015 · 1 comment
Labels

Comments

@lisandro52
Copy link
Contributor

Hi! It's me again.
After I spent some more time with the chat, I noticed that the "blop" sound wouldn't play on Firefox.
After some digging, I found that Firefox can't reproduce WAV files encoded with more than 16 bits, so I re-encoded the blop.wav file to 16 bits, and it now works properly.

Another issue I found with the sound is that the chat.js file wasn't properly loaded by Firefox, because the speechToText variable is only defined on Chrome, so I added a definition check for that and everything is running nicely! Again, I'm about to add a pull request to this issue so you can check it and merge.
Cheers!

@igorantun igorantun added the bug label Sep 4, 2015
@igorantun
Copy link
Owner

That's true, I guess I need to do more testing huh? Thank you once again for your contributions, those are always welcome and appreciated!

igorantun added a commit that referenced this issue Sep 4, 2015
Fix #23: Blop.wav not reproducing on Firefox due to enconding and JS …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants