I2P: updates for connections over I2P #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert use of panic! to return result + error. Adds PeerAddrType enum for converting address type to/from raw u8.
Adds I2P to fullnode capabilities, modifies tests accordingly. Other rustfmt changes.
Shutdown I2P streams gracefully on stop_state.
Includes `i2p_mode` and I2P peer examples in the default config file.
Adds implementation to start i2pd automatically when I2P support enabled.
6 tasks
0xmichalis
reviewed
Jun 12, 2019
| #be specified as follows: | ||
| #seeds = [\"192.168.0.1:3414\",\"192.168.0.2:3414\"] | ||
| #be specified as follows (same for other peer types): | ||
| #For TCP addresses: |
There was a problem hiding this comment.
These are IP addresses, TCP is how the packages are transmitted between the addresses in the network. If I2P and TCP are mutually exclusive protocols and that's what you want to call out here then maybe use "TCP/IP" instead of "TCP"?
0xmichalis
reviewed
Jun 12, 2019
|
|
||
| #[server.p2p_config.i2p_mode.i2p_config] | ||
| #autostart = true/false - start I2P automatically | ||
| #exclusive = true/false - exclusively connect through I2P, or also use TCP |
0xmichalis
reviewed
Jun 12, 2019
| #mode = \"Enabled\" | ||
|
|
||
| #[server.p2p_config.i2p_mode.i2p_config] | ||
| #autostart = true/false - start I2P automatically |
There was a problem hiding this comment.
all configuration options here will not be valid if uncommented, maybe try to make it as simple as possible to get started when uncommenting them so:
# start I2P automatically
# autostart = true
# exclusively connect through I2P, or also use TCP/IP
# exclusive = true
# address of local I2P server
# addr = \"127.0.0.1:7656\"
0xmichalis
reviewed
Jun 12, 2019
| .spawn() | ||
| .expect("i2pd failed to start. Ensure i2pd is on your system path."); | ||
| // allow i2pd a moment to startup before attempting SAM connection | ||
| std::thread::sleep(std::time::Duration::from_millis(100)); |
There was a problem hiding this comment.
Can't you retry the SAM connection for some time instead of relying on the sleep?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds remaining work for connecting nodes over I2P, and starting
i2pdautomatically.Some work remains (seeding over I2P, creating reverse connections, etc.), but I wanted to submit this PR for review given the upcoming version upgrade.
name: Pull Request
about: Pull Request checklist
title: ''
labels: ''
assignees: ''
If your PR is a work in progress, please feel free to create it and include a [WIP] tag in the PR name. We encourage everyone to PR early and often so that other developers know what you're working on.
Before submitting your PR for final review, please ensure that it: