Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations before 9.x.x release #175

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Sep 16, 2020

Signed-off-by: Carlos Agüero [email protected]

Signed-off-by: Carlos Agüero <[email protected]>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #175 into master will increase coverage by 5.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   83.45%   88.81%   +5.35%     
==========================================
  Files          49       47       -2     
  Lines        4915     4552     -363     
==========================================
- Hits         4102     4043      -59     
+ Misses        813      509     -304     
Impacted Files Coverage Δ
include/ignition/transport/AdvertiseOptions.hh 100.00% <ø> (ø)
include/ignition/transport/Publisher.hh 100.00% <ø> (ø)
src/AdvertiseOptions.cc 100.00% <ø> (+2.98%) ⬆️
src/NodeShared.cc 78.88% <ø> (+0.62%) ⬆️
src/Publisher.cc 100.00% <ø> (+50.27%) ⬆️
include/ignition/transport/Discovery.hh 87.91% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e7c38...11f0df0. Read the comment docs.

@chapulina chapulina merged commit 2d7eded into master Sep 16, 2020
@chapulina chapulina deleted the deprecations_9 branch September 16, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants