Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations before 9.x.x release #175

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Remove deprecations before 9.x.x release #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions include/ignition/transport/AdvertiseOptions.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,22 +114,6 @@ namespace ignition
/// \sa Scope_t.
public: void SetScope(const Scope_t &_scope);

/// \brief Serialize the options. The caller has ownership of the
/// buffer and is responsible for its [de]allocation.
/// \param[out] _buffer Destination buffer in which the options
/// will be serialized.
/// \return Number of bytes serialized.
public: size_t IGN_DEPRECATED(8) Pack(char *_buffer) const;

/// \brief Deserialize and set the options. The input buffer is
/// unpacked and used to set this object's options.
/// \param[in] _buffer Input buffer with the data to be deserialized.
public: size_t IGN_DEPRECATED(8) Unpack(const char *_buffer);

/// \brief Get the total length of the message.
/// \return Return the length of the message in bytes.
public: size_t IGN_DEPRECATED(8) MsgLength() const;

#ifdef _WIN32
// Disable warning C4251 which is triggered by
// std::unique_ptr
Expand Down Expand Up @@ -213,21 +197,6 @@ namespace ignition
/// \param[in] _newMsgsPerSec Maximum number of messages per second.
public: void SetMsgsPerSec(const uint64_t _newMsgsPerSec);

/// \brief Serialize the options. The caller has ownership of the
/// buffer and is responsible for its [de]allocation.
/// \param[out] _buffer Destination buffer in which the options
/// will be serialized.
/// \return Number of bytes serialized.
public: size_t IGN_DEPRECATED(8) Pack(char *_buffer) const;

/// \brief Unserialize the options.
/// \param[in] _buffer Input buffer with the data to be unserialized.
public: size_t IGN_DEPRECATED(8) Unpack(const char *_buffer);

/// \brief Get the total length of the message.
/// \return Return the length of the message in bytes.
public: size_t IGN_DEPRECATED(8) MsgLength() const;

#ifdef _WIN32
// Disable warning C4251 which is triggered by
// std::unique_ptr
Expand Down Expand Up @@ -285,21 +254,6 @@ namespace ignition
return _out;
}

/// \brief Serialize the options. The caller has ownership of the
/// buffer and is responsible for its [de]allocation.
/// \param[out] _buffer Destination buffer in which the options
/// will be serialized.
/// \return Number of bytes serialized.
public: size_t IGN_DEPRECATED(8) Pack(char *_buffer) const;

/// \brief Unserialize the options.
/// \param[in] _buffer Input buffer with the data to be unserialized.
public: size_t IGN_DEPRECATED(8) Unpack(const char *_buffer);

/// \brief Get the total length of the message.
/// \return Return the length of the message in bytes.
public: size_t IGN_DEPRECATED(8) MsgLength() const;

#ifdef _WIN32
// Disable warning C4251 which is triggered by
// std::unique_ptr
Expand Down
13 changes: 0 additions & 13 deletions include/ignition/transport/NodeShared.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,19 +160,6 @@ namespace ignition
const std::string &_topic,
const std::string &_msgType) const;

/// \brief Call the SubscriptionHandler callbacks (local and raw) for this
/// NodeShared.
/// \param[in] _topic The topic name
/// \param[in] _msgData The raw serialized data for the message
/// \param[in] _msgType The name of the message type
/// \param[in] _handlerInfo Information for the handlers of this node,
/// as generated by CheckHandlerInfo(const std::string&) const
public: void IGN_DEPRECATED(8.0) TriggerSubscriberCallbacks(
const std::string &_topic,
const std::string &_msgData,
const std::string &_msgType,
const HandlerInfo &_handlerInfo);

/// \brief Call the SubscriptionHandler callbacks (local and raw) for this
/// NodeShared.
/// \param[in] _info Message information.
Expand Down
Loading