Clean up ignition-tools.pc file #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hard-coded ../.. path to prefix is incorrect when the .pc file is installed to a subfolder of lib, such as for debian packages, which install to /usr/lib/x86_64-linux-gnu/pkgconfig Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
github-actions
bot
added
🏢 edifice
scpeters
commented
Feb 25, 2021
j-rivero
reviewed
Mar 1, 2021
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
j-rivero
approved these changes
Mar 22, 2021
|
A side comment: having a |
other packages may list it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes minor problem introduced by #30
Summary
We merged #30 to make our cmake and
.pcconfig files relocatable. That PR was merged before we noticed an issue in a similar PR: gazebosim/gz-cmake#129. The problem is the hard-coded../..path to prefix frompcfilediris incorrect when the.pcfile is installed to a subfolder of lib, such as for Ubuntu debian packages on amd64, which install to/usr/lib/x86_64-linux-gnu/pkgconfig. This PR includes the fix that was used for ign-cmake.I also noticed that we have include and linker flags for this package in the
.pcfile even though it has no libraries or header files. So I've removed those files as well. Of course, now the.pcfile is basically a no-op, but I'd rather have the correct relocatable path logic even if it's not used.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge