-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure relocatable config files #129
Conversation
ad0485e
to
3eb6828
Compare
…onan Signed-off-by: Stefan Profanter <[email protected]>
3eb6828
to
be2ca90
Compare
cmake/pkgconfig/ignition.pc.in
Outdated
@@ -1,4 +1,4 @@ | |||
prefix=@CMAKE_INSTALL_PREFIX@ | |||
prefix=${pcfiledir}/../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed in dartsim/dart#1527 (comment), this relative path is incorrect on Ubuntu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
I think it's good now with my fixes, based on the approach in dartsim/dart#1529 and gazebosim/sdformat#419, but I'd like another set of eyes and some testing if possible |
perhaps we can test this by including it in a prerelease (see #147) |
I'm going to merge this now and include in a prerelease to get further testing |
Signed-off-by: Steve Peters <[email protected]>
You were a bit faster merging than I was commenting: I tried this today, seems to work fine for all the scenarios I tried: colcon workspace to build ign-math7, simulate a release in Debian packaging system (using |
sorry for not waiting! we can see how the prerelease goes |
Using CMAKE_INSTALL_PREFIX causes build issues when you relocate the installed CMake package, i.e., as it is done in conan.
CMAKE_INSTALL_PREFIX should not be used in the cmake.in files directly. The
@PACKAGE_INIT@
macro initializesPACKAGE_PREFIX_DIR
correspondingly.See also:
gazebosim/gz-tools#30
gazebosim/sdformat#419
gazebosim/gazebo-classic#2782
cc @stefanbuettner