Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version numbers in config.hh #42

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Aug 27, 2020

Fix version numbers in config.hh. Before:

/* Version number */
#define IGNITION_SENSORS_MAJOR_VERSION 
#define IGNITION_SENSORS_MINOR_VERSION 
#define IGNITION_SENSORS_PATCH_VERSION 

#define IGNITION_SENSORS_VERSION "4.0"
#define IGNITION_SENSORS_VERSION_FULL "4.0.0~pre1"

#define IGNITION_SENSORS_VERSION_NAMESPACE v4

#define IGNITION_SENSORS_VERSION_HEADER "Ignition Sensors, version 4.0.0~pre1\nCopyright (C) 2014 Open Source Robotics Foundation.\nReleased under the Apache 2.0 License.\n\n"

/* #undef BUILD_TYPE_PROFILE */
/* #undef BUILD_TYPE_DEBUG */
/* #undef BUILD_TYPE_RELEASE */

#define IGN_SENSORS_PLUGIN_PATH "/usr/lib/x86_64-linux-gnu"
#define IGN_SENSORS_PLUGIN_NAME(name) std::string("ignition-sensors4-")+name

After:

/* Config.hh. Generated by CMake for ignition-sensors. */

/* Version number */
#define IGNITION_SENSORS_MAJOR_VERSION 2
#define IGNITION_SENSORS_MINOR_VERSION 9
#define IGNITION_SENSORS_PATCH_VERSION 0

#define IGNITION_SENSORS_VERSION "2.9"
#define IGNITION_SENSORS_VERSION_FULL "2.9.0"

#define IGNITION_SENSORS_VERSION_NAMESPACE v2

#define IGNITION_SENSORS_VERSION_HEADER "Ignition Sensors, version 2.9.0\nCopyright (C) 2014 Open Source Robotics Foundation.\nReleased under the Apache 2.0 License.\n\n"

/* #undef BUILD_TYPE_PROFILE */
/* #undef BUILD_TYPE_DEBUG */
/* #undef BUILD_TYPE_RELEASE */

#define IGN_SENSORS_PLUGIN_PATH "/usr/lib/x86_64-linux-gnu"
#define IGN_SENSORS_PLUGIN_NAME(name) std::string("ignition-sensors2-")+name

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from iche033 as a code owner August 27, 2020 12:51
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Aug 27, 2020
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #42 into ign-sensors2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-sensors2      #42   +/-   ##
=============================================
  Coverage         79.99%   79.99%           
=============================================
  Files                21       21           
  Lines              2059     2059           
=============================================
  Hits               1647     1647           
  Misses              412      412           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b92c1...1187e6e. Read the comment docs.

@chapulina chapulina merged commit 06ee84e into ign-sensors2 Aug 27, 2020
@chapulina chapulina deleted the caguero/fix_config_blueprint branch August 27, 2020 20:16
iche033 added a commit that referenced this pull request Sep 1, 2020
* mv hgignore

Signed-off-by: claireyywang <[email protected]>

* add gitignore

Signed-off-by: claireyywang <[email protected]>

* [ign-sensors2] Update BitBucket links (#10)

* [ign-sensors2] Update BitBucket links

Signed-off-by: Louise Poubel <[email protected]>

* [ign-sensors2] Update BitBucket links

Signed-off-by: Louise Poubel <[email protected]>

* [ign-sensors2] Workflow updates (#20)

Signed-off-by: Louise Poubel <[email protected]>

* Make topics valid (#33)

Signed-off-by: Louise Poubel <[email protected]>

* add noise to depth camera

Signed-off-by: Ian Chen <[email protected]>

* 2.9.0 release prep

Signed-off-by: Nate Koenig <[email protected]>

* Fix version numbers in config.hh (#42)

Signed-off-by: Carlos Agüero <[email protected]>

* ci fixes

Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: claireyywang <[email protected]>
Co-authored-by: chapulina <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Carlos Agüero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants