Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ign-sensors2 to ign-sensors3 #44

Merged
merged 13 commits into from
Sep 1, 2020
Merged

Merge ign-sensors2 to ign-sensors3 #44

merged 13 commits into from
Sep 1, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 29, 2020 •
edited
Loading

will rebase once #34 gets in. Replaces #34

opening PR for testing on jenkins

claireyywang and others added 11 commits April 20, 2020 13:41
@chapulina
mv hgignore
810649c 
Signed-off-by: claireyywang <[email protected]>
@chapulina
add gitignore
1fb3488 
Signed-off-by: claireyywang <[email protected]>
@chapulina
[ign-sensors2] Update BitBucket links (#10)
568cf01 
* [ign-sensors2] Update BitBucket links

Signed-off-by: Louise Poubel <[email protected]>

* [ign-sensors2] Update BitBucket links

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
[ign-sensors2] Workflow updates (#20)
3c3bb77 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Make topics valid (#33)
a2b4904 
Signed-off-by: Louise Poubel <[email protected]>
@iche033
add noise to depth camera
bb82bcc 
Signed-off-by: Ian Chen <[email protected]>
@nkoenig
Merge pull request #35 from ignitionrobotics/depth_noise
d84ef53 
Add noise to RGBD camera
2.9.0 release prep
ad5f8d4 
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig
Merge pull request #36 from ignitionrobotics/2_9_0
e8b92c1 
2.9.0 release prep
@caguero
Fix version numbers in config.hh (#42)
06ee84e 
Signed-off-by: Carlos Agüero <[email protected]>
@iche033
merge from ign-sensors2
bac1f2c 
Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 29, 2020
@codecov
Copy link

codecov bot commented Aug 29, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ign-sensors3@6f1e16a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             ign-sensors3      #44   +/-   ##
===============================================
  Coverage                ?   77.61%           
===============================================
  Files                   ?       23           
  Lines                   ?     2296           
  Branches                ?        0           
===============================================
  Hits                    ?     1782           
  Misses                  ?      514           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1e16a...2139df4. Read the comment docs.

@iche033 iche033 marked this pull request as draft August 29, 2020 05:15
@chapulina chapulina mentioned this pull request Aug 31, 2020
Closed
chapulina
chapulina suggested changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the Topic tests are failing on Windows. These are new failures for ign-sensors3, and they're also failing on ign-sensors2. We should probably fix / disable them on v2 and merge that forward to v3.

All the homebrew failures are pre-existing.

I've been adding Focal CI when merging forward from Blueprint to Citadel, but I think this can come in a follow-up PR.

.github/ci/packages.apt Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@iche033 iche033 marked this pull request as ready for review September 1, 2020 00:00
@iche033 iche033 merged commit ef3c85b into ign-sensors3 Sep 1, 2020
@iche033 iche033 deleted the 2_to_3_08282020 branch September 1, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iche033 @chapulina @nkoenig @caguero