[master] Workflow updates #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
|
@chapulina what's the magic you did to make codecov comment on the PR like in gazebosim/gz-rendering#80? |
Signed-off-by: Louise Poubel <[email protected]>
The main magic that was missing in general was installing the codecov app, which I did for all Ignition repos. This specific branch wasn't even running tests, so that was a different problem. Should be temporarily fixed by 0596a74 |
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
Coverage ? 59.63%
=========================================
Files ? 16
Lines ? 976
Branches ? 0
=========================================
Hits ? 582
Misses ? 394
Partials ? 0 Continue to review full report at Codecov.
|
iche033
approved these changes
May 11, 2020
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masteronce that's merged: gazebo-tooling/action-gz-ci#7