Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign-rendering3] Workflow updates #80

Merged
merged 2 commits into from
May 8, 2020

Conversation

chapulina
Copy link
Contributor

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 2, 2020
@chapulina chapulina requested a review from iche033 May 2, 2020 03:17
@iche033
Copy link
Contributor

iche033 commented May 4, 2020

should I expect to see a codecov.io comment in the PR?

Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (ign-rendering3@44e8f39). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             ign-rendering3     #80   +/-   ##
================================================
  Coverage                  ?   7.81%           
================================================
  Files                     ?      25           
  Lines                     ?    1689           
  Branches                  ?       0           
================================================
  Hits                      ?     132           
  Misses                    ?    1557           
  Partials                  ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e8f39...cf09a25. Read the comment docs.

@chapulina
Copy link
Contributor Author

should I expect to see a codecov.io comment in the PR?

Yup, fixed!

@chapulina
Copy link
Contributor Author

The test coverage is really low for all branches. I'm not sure why and didn't look too close at the logs, some guesses:

  • Optix not being installed means we lose about 1/3 of coverage
  • GitHub actions doesn't support GPU tests

At least some tests are running though, so I think we can close #44.

@chapulina chapulina merged commit 2d247a4 into ign-rendering3 May 8, 2020
@chapulina chapulina deleted the workflow_updates_ign-rendering3 branch May 8, 2020 14:44
@iche033
Copy link
Contributor

iche033 commented May 8, 2020

I think it's also running for ogre 1.x only and not ogre 2.1 so another 1/3 of coverage lost

@chapulina
Copy link
Contributor Author

Oh that reminds me of this issue, which I think I put on ign-gazebo by mistake, when I meant to put it on ign-rendering gazebosim/gz-sim#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants