Added LidarVisual implementation for Ogre1, empty classes for Ogre2 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
ahcorde
requested changes
Jun 20, 2020
There was a problem hiding this comment.
Please run bash tools/code_check.sh inside the project folder and fix the linter errors in the files that you are adding to the project.
./src/LidarVisual_TEST.cc:105: Lines should be <= 80 characters long [whitespace/line_length] [2]
./include/ignition/rendering/LidarVisual.hh:36: Tab found; better to use spaces [whitespace/tab] [1]
./include/ignition/rendering/LidarVisual.hh:37: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
...
ahcorde
reviewed
Jun 20, 2020
ahcorde
reviewed
Jun 20, 2020
ahcorde
reviewed
Jun 20, 2020
mihirk284
changed the title
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
mihirk284
force-pushed
the
temp_lidar_visual
branch
from
cee20c0 to
a16a92f
Compare
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
ahcorde
requested changes
Jun 21, 2020
ahcorde
reviewed
Jun 21, 2020
…tiple Lidars Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
mihirk284
force-pushed
the
temp_lidar_visual
branch
from
ae11b6e to
7221f7e
Compare
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
mihirk284
force-pushed
the
temp_lidar_visual
branch
from
5b5e49f to
9115a53
Compare
Signed-off-by: Mihir Kulkarni <[email protected]>
|
Added example of a GPU rays sensor with data collected lidar data being visualised |
iche033
reviewed
Jun 30, 2020
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
iche033
reviewed
Jun 30, 2020
Signed-off-by: Mihir Kulkarni <[email protected]>
… laserPoints Signed-off-by: Mihir Kulkarni <[email protected]>
iche033
reviewed
Jul 2, 2020
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
Signed-off-by: Mihir Kulkarni <[email protected]>
iche033
requested changes
Jul 6, 2020
ogre/src/OgreLidarVisual.cc
Outdated
| line->setMaterial("Lidar/BlueStrips"); | ||
| #else | ||
| line->setMaterial( | ||
| this->Scene()->Material("Lidar/BlueStrips")->Clone()); |
There was a problem hiding this comment.
This returns an ignition::rendering::MaterialPtr object but setMaterial expects an Ogre::MateiralPtr object. So windows build is still failing, see console output
You'll need to get the material using ogre's material manager:
Ogre::MaterialPtr mat = Ogre::MaterialManager::getSingleton().getByName("Lidar/BlueStrips");
Signed-off-by: Mihir Kulkarni <[email protected]>
ahcorde
approved these changes
Jul 7, 2020
|
It looks like this change introduced four new test failures on Windows: |
hmm unfortunately that's expected when new tests are added since windows build is not working properly. There is an attempt to fix windows CI in pull request #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see issue ignitionrobotics/ign-rendering#84.
I have added lidar visualisation for Ogre1 and an example for the same.
The following image shows an example of the LidarVisual with 3 vertical sets of rays.
@ahcorde Please do check the PR and let me know if there are any changes. ( This PR is different from the previous one so that it would be easier to review the code as it is separated cleanly per commit.)