-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port codecov to new configuration #170
Conversation
See gazebo-tooling/action-gz-ci#32 Signed-off-by: Jose Luis Rivero <[email protected]>
Would it be worth merging this and then forward porting it to |
I'm also seeing a failure in GitHub actions:
|
@j-rivero friendly ping |
thanks! I've disabled codecov, if I'm not wrong there is no support in this repository for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've disabled codecov, if I'm not wrong there is no support in this repository for it
All checks pass, so I'm approving this 👍 @scpeters or @chapulina, beofre we merge this, can one of you confirm that disabling codecov in this repository is okay?
Yup, I think it should be ok because we aren't generating coverage data either for the tests in |
Sounds good 👍 merging! |
See gazebo-tooling/action-gz-ci#32
Signed-off-by: Jose Luis Rivero [email protected]