Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov badge from README #172

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented May 14, 2021

Signed-off-by: Ashton Larkin [email protected]

Summary

#170 disables codecov, since it isn't being used in this repository. So, I believe it would also make sense to remove the codecov badge from the README. Is anyone opposed to this change?

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@adlarkin adlarkin requested a review from chapulina May 14, 2021 18:31
@adlarkin adlarkin requested review from j-rivero and mxgrey as code owners May 14, 2021 18:31
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels May 14, 2021
@adlarkin adlarkin force-pushed the adlarkin/remove_codecov_badge branch from da55a7a to 3b78702 Compare May 14, 2021 18:41
@adlarkin adlarkin merged commit 3b78702 into ign-cmake2 May 14, 2021
@adlarkin adlarkin deleted the adlarkin/remove_codecov_badge branch May 14, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants