Find Ogre 2-2

[ahcorde]

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Related with this issue gazebosim/gz-rendering#223

Summary

This PR allows to find OGRE 2-2

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[mjcarroll]

I think we're going to have to maintain compatibility with both for a little bit, since we aren't bumping the major version on ign-cmake. This will actually stop OGRE 2.1 from being found.

[j-rivero]

Thinking on the future and to avoid the assumption that not 2 is 1, could work something like:

message(STATUS "-- Finding OGRE 2.${IgnOGRE2_FIND_VERSION_MINOR}")
set(OGRE2_INSTALL_PATH "OGRE-2.${IgnOGRE2_FIND_VERSION_MINOR}")

instead of the whole if block?

[mjcarroll]

Makes sense

[j-rivero]

Testing the thing in a colcon workspace with current ogre-2.1 package + rendering4, the thing compiles just fine. I would not expect regressions with current changes.

We probably need to make some changes to make it work on Windows with different package managers/buildsystems. That could be done in a different PR.

I just notice that the ogre-2.2 example can work with ogre-2.1 using current versions of ign-cmake from .debs returning ogre-2.1 paths. We probably need to implement checks on the consumers of this ign-cmake version (i.e: ign-rendering) to pull these changes into the mix to work correctly.