Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[sint] Fix compatibility with Smack 4.5.0-beta2
Due to a change in Smack 4.5.0-beta2, test execution of (all) SINT tests is aborted when `FormTest` is executed. It appears that Smack now has more strict argument validation when setting thread IDs on message stanzas. This validation should not fail for the tests that are shipped with Smack. This is the stack trace when executing the failing test (which no longer occurs after the change in this commit is applied): ``` Exception in thread "main" java.lang.IllegalArgumentException: thread must not be null nor empty at org.jivesoftware.smack.util.StringUtils.requireNotNullNorEmpty(StringUtils.java:533) at org.jivesoftware.smack.packet.Message$Thread.<init>(Message.java:326) at org.jivesoftware.smack.packet.MessageBuilder.setThread(MessageBuilder.java:70) at org.jivesoftware.smack.packet.MessageBuilder.setThread(MessageBuilder.java:66) at org.jivesoftware.smackx.xdata.FormTest.testFilloutForm(FormTest.java:133) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.lambda$runTests$0(SmackIntegrationTestFramework.java:476) at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.runConcreteTest(SmackIntegrationTestFramework.java:556) at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework$PreparedTest.run(SmackIntegrationTestFramework.java:764) at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.runTests(SmackIntegrationTestFramework.java:544) at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.run(SmackIntegrationTestFramework.java:277) at org.igniterealtime.smack.inttest.SmackIntegrationTestFramework.main(SmackIntegrationTestFramework.java:115) ```
- Loading branch information