Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove github.com/gookit/color #4557

Merged
merged 2 commits into from
Mar 9, 2025
Merged

refactor: remove github.com/gookit/color #4557

merged 2 commits into from
Mar 9, 2025
+39 −22

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 8, 2025

close #2432

Description

  • remove github.com/gookit/color;
  • use session.print instead cmd.print;

@Pantani Pantani self-assigned this Mar 8, 2025
@Pantani Pantani requested review from salmad3 and toschdev as code owners March 8, 2025 21:00
@julienrbrt julienrbrt changed the title fix: remove github.com/gookit/color refactor: remove github.com/gookit/color Mar 9, 2025
julienrbrt
julienrbrt approved these changes Mar 9, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt merged commit 680d0af into main Mar 9, 2025
41 of 46 checks passed
@julienrbrt julienrbrt deleted the fix/use-only-session branch March 9, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPDATE: Unify all terminal output coloring with pkg/cliui/color
2 participants
@Pantani @julienrbrt