Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump to go 1.24 #4509

Merged
merged 33 commits into from
Mar 8, 2025
Merged

build(deps): bump to go 1.24 #4509

merged 33 commits into from
Mar 8, 2025

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 14, 2025

Bump cli + app to Go 1.24 and use the new tool pattern: https://go.dev/doc/modules/managing-dependencies#tools

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:internal labels Feb 14, 2025
@julienrbrt julienrbrt added the skip-changelog Don't check changelog for new entries label Feb 14, 2025
@julienrbrt
Copy link
Member Author

Super weird, looks like the library used by json library <cosmossdk.io/log doesn't support Go 1.24 yet.

@julienrbrt
Copy link
Member Author

We can go further after bytedance/sonic#741

julienrbrt added a commit that referenced this pull request Feb 17, 2025
julienrbrt added a commit that referenced this pull request Feb 17, 2025
* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix
mergify bot pushed a commit that referenced this pull request Feb 17, 2025
* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix

(cherry picked from commit 4abea76)

# Conflicts:
#	ignite/config/chain/base/config.go
julienrbrt added a commit that referenced this pull request Feb 17, 2025
* feat(services): add faucet fee config (#4513)

* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix

(cherry picked from commit 4abea76)

# Conflicts:
#	ignite/config/chain/base/config.go

* conflict

---------

Co-authored-by: Julien Robert <[email protected]>
@julienrbrt julienrbrt marked this pull request as ready for review March 7, 2025 12:07
@julienrbrt julienrbrt removed the skip-changelog Don't check changelog for new entries label Mar 7, 2025
@julienrbrt julienrbrt marked this pull request as draft March 7, 2025 12:56
@julienrbrt julienrbrt marked this pull request as ready for review March 7, 2025 13:44
@julienrbrt
Copy link
Member Author

@Pantani should be good to review again

@julienrbrt julienrbrt enabled auto-merge (squash) March 7, 2025 17:10
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT
ACK, tested with a new chain and a chain scaffolded with a preview Golang version

@julienrbrt julienrbrt merged commit 6a6412a into main Mar 8, 2025
40 of 45 checks passed
@julienrbrt julienrbrt deleted the julien/124 branch March 8, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants