Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove oracle support (backport #3993) #4233

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 2, 2024

Instead of maintaining oracle support, I propose, as it is deprecated, we simply drop it: #3727.
There is a wide choice of oracle that people can integrate with, and we should, if we want to continue support, after #3933 make it an app per oracle service.

This avoids maintaining those plush files as well to keep them compatible with the latest ignite and sdk development.

closes: #3727


This is an automatic backport of pull request #3993 done by Mergify.

* refactor!: remove oracle support

* changelog

---------

Co-authored-by: Danilo Pantani <[email protected]>
(cherry picked from commit 496daaf)

# Conflicts:
#	ignite/cmd/scaffold_band.go
#	ignite/services/scaffolder/oracle.go
Copy link
Contributor Author

mergify bot commented Jul 2, 2024

Cherry-pick of 496daaf has failed:

On branch mergify/bp/release/v28.x.y/pr-3993
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 496daaf0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/cmd/scaffold.go
	modified:   ignite/services/scaffolder/component.go
	modified:   ignite/services/scaffolder/component_test.go
	deleted:    ignite/templates/ibc/files/oracle/proto/{{appName}}/{{moduleName}}/{{queryName}}.proto.plush
	deleted:    ignite/templates/ibc/files/oracle/x/{{moduleName}}/keeper/msg_{{queryName}}.go.plush
	deleted:    ignite/templates/ibc/files/oracle/x/{{moduleName}}/keeper/query_{{queryName}}.go.plush
	deleted:    ignite/templates/ibc/files/oracle/x/{{moduleName}}/keeper/{{queryName}}.go.plush
	deleted:    ignite/templates/ibc/files/oracle/x/{{moduleName}}/oracle.go.plush
	deleted:    ignite/templates/ibc/files/oracle/x/{{moduleName}}/types/oracle.go.plush
	deleted:    ignite/templates/ibc/files/oracle/x/{{moduleName}}/types/{{queryName}}.go.plush
	deleted:    ignite/templates/ibc/files/oracle/x/{{moduleName}}/types/{{queryName}}_test.go.plush
	deleted:    ignite/templates/ibc/oracle.go
	modified:   ignite/templates/ibc/placeholders.go
	modified:   ignite/templates/module/create/files/ibc/x/{{moduleName}}/module/module_ibc.go.plush
	modified:   integration/ibc/cmd_ibc_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: ignite/cmd/scaffold_band.go
	deleted by them: ignite/services/scaffolder/oracle.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:templates component:configs component:cmd type:services Service-related issues. labels Jul 2, 2024
@Pantani Pantani enabled auto-merge (squash) July 2, 2024 14:39
@julienrbrt
Copy link
Member

That's a breaking change, we shouldn't backport it in a minor or patch version.

@julienrbrt julienrbrt closed this Jul 2, 2024
auto-merge was automatically disabled July 2, 2024 18:16

Pull request was closed

@mergify mergify bot deleted the mergify/bp/release/v28.x.y/pr-3993 branch July 2, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants