-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(template): remove client.ReadPersistentCommandFlags
#4132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you still need to read the flags before. Blocking this until I test this thoroughly. But from my memory this is in purpose.
Now that your changes (cosmos/cosmos-sdk#20356) have been merged and backported to v0.50 in the SDK, let me check if this works now. |
the steps to initialize the client instance:
I don't think the step 3 is necessary. and by the way, refer to the viper documentation, the flag has higher priority https://github.com/spf13/viper?tab=readme-ov-file#why-viper |
This is required, otherwise |
The
client.SetCmdClientContextHandler
has theclient.ReadPersistentCommandFlags
https://github.com/cosmos/cosmos-sdk/blob/0c91044220403e7b899ad0e51ccd2d4e5d66a901/client/cmd.go#L30-L37