Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove all import placeholders using the xast pkg #4004

Merged
merged 7 commits into from
Mar 8, 2024
Merged

feat: remove all import placeholders using the xast pkg #4004

merged 7 commits into from
Mar 8, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 8, 2024 •
edited
Loading

Description

  • Remove all ignite placeholder into the .plush imports and add them using the xast.AppendImports function;
  • Remove the keeper definition placeholder into the app.go.plush and add them using the xast.ModifyFunction function;
  • Remove unused placeholders;

@Pantani Pantani self-assigned this Mar 8, 2024
@Pantani Pantani changed the title feat: remove all import placeholders feat: remove all import placeholders using the xast pkg Mar 8, 2024
@Pantani Pantani marked this pull request as ready for review March 8, 2024 02:39
@Pantani Pantani marked this pull request as draft March 8, 2024 02:49
@Pantani Pantani marked this pull request as ready for review March 8, 2024 06:16
julienrbrt
julienrbrt approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

love the imports' replacement, but a bit less the magic look of the keeper addition.

@Pantani Pantani enabled auto-merge (squash) March 8, 2024 18:57
@Pantani Pantani merged commit 59400a5 into main Mar 8, 2024
46 checks passed
@Pantani Pantani deleted the feat/remove-import-placeholders branch March 8, 2024 19:55
@jeronimoalbi jeronimoalbi mentioned this pull request Mar 11, 2024
Closed
@julienrbrt julienrbrt mentioned this pull request Mar 15, 2024
Merged
julienrbrt pushed a commit that referenced this pull request May 29, 2024
@Pantani @julienrbrt
feat: remove all import placeholders using the xast pkg (#4004)
00c8872 
* remove all import placeholders

* add changelog

* remove unused placeholders

* fix wrong import path

* improve readbility

* remove keeper definition placeholder

---------

Co-authored-by: Pantani <Pantani>
@Pantani Pantani added the backport/v28.x.y Backport to v28.x.y label Jul 2, 2024
mergify bot pushed a commit that referenced this pull request Jul 2, 2024
@Pantani @mergify
feat: remove all import placeholders using the xast pkg (#4004)
42f332c 
* remove all import placeholders

* add changelog

* remove unused placeholders

* fix wrong import path

* improve readbility

* remove keeper definition placeholder

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit 59400a5)

# Conflicts:
#	ignite/templates/ibc/placeholders.go
@mergify mergify bot mentioned this pull request Jul 2, 2024
Closed
@Pantani Pantani removed the backport/v28.x.y Backport to v28.x.y label Jul 3, 2024
@julienrbrt julienrbrt mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages component:templates
Projects
Ignite CLI Masterboard
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pantani @jeronimoalbi @julienrbrt