Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove oracle support #3993

Merged
merged 3 commits into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@

### Changes

- [#3993](https://github.com/ignite/cli/pull/3993) Oracle scaffolding was deprecated and has been removed
- [#3959](https://github.com/ignite/cli/pull/3959) Remove app name prefix from the `.gitignore` file
- [#3962](https://github.com/ignite/cli/pull/3962) Rename all RPC endpoints and autocli commands generated for `map`/`list`/`single` types
- [#3962](https://github.com/ignite/cli/pull/3962) Rename all RPC endpoints and autocli commands generated for `map`/`list`/`single` types
- [#3972](https://github.com/ignite/cli/pull/3972) Skip Ignite app loading for some base commands that don't allow apps
- [#3976](https://github.com/ignite/cli/pull/3976) Remove error checks for Cobra command value get calls
- [#3983](https://github.com/ignite/cli/pull/3983) Bump `cosmos-sdk` to `v0.50.4` and `ibc-go` to `v8.1.0`
Expand Down
1 change: 0 additions & 1 deletion ignite/cmd/scaffold.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ with an "--ibc" flag. Note that the default module is not IBC-enabled.
NewScaffoldMessage(),
NewScaffoldQuery(),
NewScaffoldPacket(),
NewScaffoldBandchain(),
NewScaffoldVue(),
NewScaffoldReact(),
)
Expand Down
88 changes: 0 additions & 88 deletions ignite/cmd/scaffold_band.go

This file was deleted.

27 changes: 0 additions & 27 deletions ignite/services/scaffolder/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ func checkForbiddenComponentName(name multiformatname.Name) error {
// Check with names already used from the scaffolded code
switch name.LowerCase {
case
"oracle",
"logger",
"keeper",
"query",
Expand Down Expand Up @@ -199,32 +198,6 @@ func checkGoReservedWord(name string) error {
return nil
}

// checkForbiddenOracleFieldName returns true if the name is forbidden as an oracle field name.
//
// Deprecated: This function is no longer maintained.
func checkForbiddenOracleFieldName(name string) error {
mfName, err := multiformatname.NewName(name, multiformatname.NoNumber)
if err != nil {
return err
}

// Check with names already used from the scaffolded code
switch mfName.UpperCase {
case
"CLIENTID",
"ORACLESCRIPTID",
"SOURCECHANNEL",
"CALLDATA",
"ASKCOUNT",
"MINCOUNT",
"FEELIMIT",
"PREPAREGAS",
"EXECUTEGAS":
return errors.Errorf("%s is used by Ignite scaffolder", name)
}
return nil
}

// containsCustomTypes returns true if the list of fields contains at least one custom type.
func containsCustomTypes(fields []string) bool {
for _, field := range fields {
Expand Down
2 changes: 1 addition & 1 deletion ignite/services/scaffolder/component_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func TestCheckForbiddenComponentName(t *testing.T) {
},
{
name: "should prevent forbidden name",
compName: "oracle",
compName: "genesis",
shouldError: true,
},
}
Expand Down
127 changes: 0 additions & 127 deletions ignite/services/scaffolder/oracle.go

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading