fix: remove ignite-hq/cli from dependency list #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, when go mod download failed, only "exit status 1" was printed. I replicated the logic of other go command runners.
go1.18 handles better the dependencies than go1.16. With go1.16 it's not possible to get ride of ignite-hq/cli dependency, because logically tendermint/spn@latest depends on ignite/[email protected], which depends on an older tendermint/spn that itself depends on ignite-hq/cli. Fortunately, go1.18 can handle that and removes the dependency to ignite-hq, don't ask me how!
tbruyelle
requested review from
fadeev,
ilgooz,
lumtis,
ivanovpetr and
jeronimoalbi
as code owners
tbruyelle
changed the title
tbruyelle
changed the title
lumtis
reviewed
Jul 12, 2022
ignite/templates/module/create/ibc/testutil/keeper/ibc.go.plush
Outdated
Show resolved
Hide resolved
lumtis
approved these changes
Jul 15, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
The change fixes a go command error when scaffolding a chain (see ignite#2618), because go cannot fetch `ignite-hq/cli` despite the github redirection. To remove `ignite-hq/cli` from the dependency list, I had to : - upgrade `spn` to latest (so it depends on `ignite/[email protected]` rather than `ignite-hq/cli`) - upgrade go to 1.18 in `go.mod.plush` (or else `ignite/[email protected]` adds a dependency to an older `spn` which in turn adds a dependency to `ignite-hq/cli`) Bonus: - improve `go mod download` error report : add the binary output in addition to `Exit status 1`. - fix test because of upgrade to ibc-go 3.0.1, where some parameters can't be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change fixes a go command error when scaffolding a chain (see #2618), because go cannot fetch
ignite-hq/clidespite the github redirection.To remove
ignite-hq/clifrom the dependency list, I had to :spnto latest (so it depends onignite/[email protected]rather thanignite-hq/cli)go.mod.plush(or elseignite/[email protected]adds a dependency to an olderspnwhich in turn adds a dependency toignite-hq/cli)Bonus:
go mod downloaderror report : add the binary output in addition toExit status 1.