docs(hello.md): Update Hello Tutorial #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added further clarity on line 248 (You can skip this step if you already have your blockchain running)
ChrisValle
requested review from
fadeev,
ilgooz,
lumtis,
Pantani and
ivanovpetr
as code owners
soniasingla
previously approved these changes
Apr 4, 2022
barriebyron
reviewed
Apr 4, 2022
docs/guide/hello.md
Outdated
Comment on lines
248
to
251
| 5. Now you're ready to start your blockchain (You can skip this step if you already have your blockchain running): | ||
|
|
||
| ```go | ||
| starport chain serve |
There was a problem hiding this comment.
Suggested change
| 5. Now you're ready to start your blockchain (You can skip this step if you already have your blockchain running): | |
| ```go | |
| starport chain serve |
There was a problem hiding this comment.
@ChrisValle great catch! I like this thorough approach. Let's just delete this step altogether since the chain is already running
go Chris go!!
barriebyron
approved these changes
Apr 4, 2022
soniasingla
approved these changes
Apr 4, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* (docs)Update Hello Added further clarity on line 248 (You can skip this step if you already have your blockchain running) * Used auto-numbering and removed step Co-authored-by: Chris Valle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed a step since the blockchain is already running
https://deploy-preview-2248--starport-docs.netlify.app/guide/hello.html
@soniasingla Auto-numbering in markdown we just use #1, also deleted step after discussion with @barriebyron