Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodetime): temporarily use x64 build for M1 #1267

Merged
merged 3 commits into from
Jun 22, 2021
Merged

feat(nodetime): temporarily use x64 build for M1 #1267

merged 3 commits into from
Jun 22, 2021

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jun 20, 2021

What does this PR does?

  • Add mac M1 support (darwin arm64);

For now, we can use the nodetime amd64 binary. The macOS can run it using the Rosetta 2, but it's not the proper way. We need to build the Nodetime compiled for macOS arm64 in the future.

The nodetime for macOS-arm64 build with pkg is experimental, and it's not working properly. Also, the final executable needs to be signed with codesign utility of macOS. We should create a Tendermint Ad-hoc certificate for it.

Changes

  • Create the binary_darwin_arm64.go using amd64 binary

How to test?

$ make install

@Pantani Pantani requested review from fadeev, ilgooz and lumtis as code owners June 20, 2021 23:25
@Pantani Pantani changed the title add binary_darwin_arm64.go file for darwin arm64 build feat: add binary_darwin_arm64.go file for darwin arm64 build Jun 20, 2021
@ilgooz ilgooz changed the title feat: add binary_darwin_arm64.go file for darwin arm64 build feat(nodetime): temporarily use x64 build for M1 Jun 21, 2021
@ilgooz ilgooz merged commit 180b9f8 into ignite:develop Jun 22, 2021
@Pantani Pantani deleted the feat/arm-build branch June 22, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants