-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: macOS arm64 support #1263
Conversation
Why'd you close the PR? it is of course super interesting :) |
@faddat the nodetime for ARM64 is returning some errors, I'll try to fix it today and open the PR again |
@faddat great!! |
@Pantani Can you please provide more info about these errors? Are you seeing random bytes printed to the stdout? Please check this branch, it should be able to produce binaries for all platforms without any error. |
@ilgooz I bumped the And, also, I added the ARM binary: It's working, but when I try to scaffold a new project ( |
@Pantani we still need to disable byte code generation as in the branch I shared in my previous comment, otherwise build process won't be successful on linux machines even if it seems to. For the error you mention, I beleive it's a bug caused by |
That was the right issue. I do think it's relevant. |
@faddat, @ilgooz I was trying to figure out how is the reason, but we need to go more deeply into the binaries built by |
And personally, I think the issue is #1201. Everything I am seeing is pointing to "something" in the build env that we aren't aware of or doing. Here's where I grabbed @ilgooz's attempt and merged in develop: https://github.com/faddat/starport/tree/starport-arm-ilker |
What does this PR does?
Changes
pkg
version;nodetime
binary;linux-x64
andmacos-x64
binaries;How to test?