avoid injecting xrefs inside other xrefs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
reviewed
Aug 21, 2022
| @@ -135,6 +135,9 @@ def apply(self): | |||
| if isinstance(parent, (nodes.literal, nodes.FixedTextElement)): | |||
| # ignore inline and block literal text | |||
| continue | |||
| if isinstance(parent, nodes.reference): | |||
There was a problem hiding this comment.
This looks safe to add 👍
I had to add it to my fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I wanted to make a link to another project's issue, like this:
but this extension was still picking up on the
#126portion of the reference and converting that into a reference inside a reference.I don't think it ever makes sense to produce nested links like that, so this patch makes the extension just skip reference nodes entirely (in the same way it skips literal nodes).