Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance readme documentation #1

Open
wants to merge 2 commits into
base: wicket-7.x
Choose a base branch
from
Open

Enhance readme documentation #1

wants to merge 2 commits into from

Conversation

lalmeras
Copy link
Member

Hi,

I propose the following change on README after a globally successful try of you module, but some difficulty I step into, and I want to address in this PR:

  • quickly document [/current/|//] path behavior, as other webjars implementation generally prefer to handle version a an optional value,
  • explicitly state that /current/ behavior is not available for resource delivery by container,
  • be more precise about webjars resource delivery by container: I use tomcat, and I cannot access directly to resources, surely because of some url filtering or specific tomcat configuration I have. But I wrongly start to investigate into wicket-webjars while it has absolutely no role into this feature.

@lalmeras
Enhance readme documentation
9b9b5ef 
More information about direct resource delivery by Servlet 3 container and requirement
for an explicit version.

Some insights on the expected format in Webjars*ResourceReference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lalmeras