Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock issue in CleanMessagesExecutor #898

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

hubcio
Copy link
Collaborator

@hubcio hubcio commented Apr 12, 2024

This commit resolves a deadlock by acquiring a write lock on the system
once instead of multiple times within the CleanMessagesExecutor. The
redundant system.write() calls have been removed, ensuring that the
metrics are updated without the need for additional locks.

This closes #897.

This commit resolves a deadlock by acquiring a write lock on the system
once instead of multiple times within the CleanMessagesExecutor. The
redundant system.write() calls have been removed, ensuring that the
metrics are updated without the need for additional locks.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8661543493

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 82.585%

Files with Coverage Reduction New Missed Lines %
sdk/src/clients/client.rs 1 49.74%
server/src/streaming/segments/storage.rs 1 49.91%
Totals Coverage Status
Change from base Build 8658041641: 0.02%
Covered Lines: 22521
Relevant Lines: 27270

💛 - Coveralls

@hubcio hubcio merged commit 9e180ad into master Apr 12, 2024
17 checks passed
@hubcio hubcio deleted the server_deadlock branch April 12, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unresponsive HTTP and TCP server
3 participants